Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing OCI helm chart with semver version range fails if tag has a v prefix #358

Closed
reegnz opened this issue Feb 9, 2024 · 2 comments
Closed
Labels
bug This issue describes a defect or unexpected behavior

Comments

@reegnz
Copy link
Contributor

reegnz commented Feb 9, 2024

What steps did you take:
[A clear and concise description steps that can be used to reproduce the problem.]

I tried syncing a helm OCI chart from here: https://github.com/metacontroller/metacontroller/pkgs/container/metacontroller-helm/153598243?tag=v4.11.7

The chart version is published with a v prefix (which is quite common).

I used the following vendir.yml

---
apiVersion: vendir.k14s.io/v1alpha1
kind: Config
directories:
- path: vendor
  contents:
  - path: metacontroller
    helmChart:
      name: metacontroller/metacontroller-helm
      version: ^4.0
      repository:
        url: oci://ghcr.io

What happened:

❯ vendir sync
Fetching: vendor + metacontroller (helm chart from oci://ghcr.io@metacontroller/metacontroller-helm:^4.0)

vendir: Error: Syncing directory 'vendor':
  Syncing directory 'metacontroller' with helm chart contents:
    Helm chart pull: exit status 1 (stderr: Error: Unable to locate any tags in provided repository: oci://ghcr.io/metacontroller/metacontroller-helm

If I change the version to 4.11.7 the sync also fails.
Only case when the sync works is if I explicitly declare the tag with a v prefix like v4.11.7 but then semver rules don't work eg. v4.0.

What did you expect:
I expected the vendir command to resolve the latest version to 4.11.7, sync that, and write that version into the lock file.

Anything else you would like to add:

Environment:

  • vendir version (execute vendir --version): 0.39.0
  • OS (e.g. from /etc/os-release): MacOS Sonoma 14.3

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@reegnz reegnz added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels Feb 9, 2024
@reegnz
Copy link
Contributor Author

reegnz commented Feb 9, 2024

OTOH this might be a helm issue, so I'll also throw the topic into the project's github.

@reegnz
Copy link
Contributor Author

reegnz commented Feb 9, 2024

Opened an issue with the chart maintainer: metacontroller/metacontroller#946

@reegnz reegnz closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
@github-actions github-actions bot removed the carvel-triage This issue has not yet been reviewed for validity label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior
Projects
Archived in project
Development

No branches or pull requests

1 participant