Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for nested imgpkg bundles in the caching logic #399

Open
100mik opened this issue Sep 25, 2024 · 0 comments · May be fixed by #401
Open

Account for nested imgpkg bundles in the caching logic #399

100mik opened this issue Sep 25, 2024 · 0 comments · May be fixed by #401
Assignees
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.

Comments

@100mik
Copy link
Contributor

100mik commented Sep 25, 2024

Describe the problem/challenge you have
imgpkg bundles might contain references to other imgpkg bundles (as in the case of PackageRepository bundles). Purely SHA based caching might lead to nested content being pulled from an older registry when a migration is attempted.

Relevant bug in kapp-controller: carvel-dev/kapp-controller#1603

Describe the solution you'd like
Instead of accounting for just the SHA as a key while caching content, the entire registry URL should be considered.

Anything else you would like to add:
This would not be an issue in a kapp-controller upgrade scenario as an update would roll out new pods, dropping the old cache.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@100mik 100mik added enhancement This issue is a feature request carvel-triage This issue has not yet been reviewed for validity labels Sep 25, 2024
@100mik 100mik self-assigned this Sep 25, 2024
@100mik 100mik added carvel-accepted This issue should be considered for future work and that the triage process has been completed priority/important-soon Must be staffed and worked on currently or soon. and removed carvel-triage This issue has not yet been reviewed for validity labels Sep 25, 2024
@100mik 100mik linked a pull request Oct 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-soon Must be staffed and worked on currently or soon.
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant