-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add json parser to build attribute in duktape #166
Conversation
Signed-off-by: stonex <1479765922@qq.com>
@EmperorYP7 @divy9881 @noob20000405 please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Well done @sheny1xuan 🙌🏻 However, the variable naming should be consistent throughout the code. (pascalCase)
I was wondering if we actually need the |
@EmperorYP7 then we can remove it I think |
Signed-off-by: stonex <1479765922@qq.com>
I think so, but I think we should make JSON parse comprehensive support the old work that |
@sheny1xuan good point! |
🎉 This PR is included in version 1.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: stonex 1479765922@qq.com
Description
double
,int
,bool
,string
andobject
.