feat: add eval regex and test #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EmperorYP7 @divy9881 @noob20000405 please review |
|
@EmperorYP7 plz review |
EmperorYP7
requested changes
Nov 18, 2021
Signed-off-by: stonex <1479765922@qq.com>
|
I think this pr can be merged now, and I will make a new pr base on this. @hsluoyz @EmperorYP7 |
|
🎉 This PR is included in version 1.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: stonex 1479765922@qq.com
Description
eavl()whether in the model matcher expression. Add a regex to test whether haseval.ReplaceEvalWithMapreplace theeval(tokens)by tokens value.HasEval()andReplaceEvalWithMap().