Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included nlohmann::json interfere with project dependencies #168

Closed
NewbieOrange opened this issue Nov 17, 2021 · 4 comments · Fixed by #169
Closed

Included nlohmann::json interfere with project dependencies #168

NewbieOrange opened this issue Nov 17, 2021 · 4 comments · Fixed by #169
Assignees
@hsluoyz
Labels
bug Something isn't working released

Comments

@NewbieOrange
Copy link
Contributor

Description

The recently added nlohmann::json has an older version than my project's minimal requirement, and casuing it failed to build.

Can we include a customized version of the json.hpp (adding casbin namespace?) to avoid interferences?
@casbin-bot
Copy link
Member

@EmperorYP7 @divy9881 @noob20000405 @sheny1xuan

@casbin-bot casbin-bot added the question Further information is requested label Nov 17, 2021
@sheny1xuan
Copy link
Contributor

Of course, we can include a customized version of the json.hpp, adding it to casbin namespace to avoid different version of the json lib.
Maybe we should update the version of nlohmann::json at the same time. What's version should be better? 3.9 or 3.10?

@NewbieOrange
Copy link
Contributor Author

Newer is better, probably :)

@sheny1xuan sheny1xuan mentioned this issue Nov 18, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 1.41.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hsluoyz hsluoyz added bug Something isn't working and removed question Further information is requested labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update json version to 3.10.1
4 participants
@hsluoyz @NewbieOrange @sheny1xuan @casbin-bot