fix: set_target_properties's VERSION #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#205
Description
In "./casbin/CMakeLists.txt", line 79~82,
well, if i integrate
casbin-cpp
to my project as a thirdparty via cmake, theVERSION
property will refer to my top project'sVERSION
property, causeCMAKE_PROJECT_VERSION
means that, so it's unreasonable.Instead, by
the
VERSION
property will refer tocasbin-cpp
's top project'sVERSION
property, i think that's what we want.