feat: add support for add_domain_matching_function #165
Conversation
|
@hsluoyz @techoner plz review |
|
@dhait plz review. |
There was a problem hiding this comment.
Please refer to the implementation in Casbin(Go) completely : https://github.com/casbin/casbin/blob/aeeb9e6854e26bdbe22145e212b92c930df3036d/rbac/default-role-manager/role_manager.go
| if self.matching_func is None: | ||
| return name in self.all_roles.keys() | ||
| def has_role(self, role): | ||
|
|
There was a problem hiding this comment.
Please remove has_role() create_role()，refer to RoleManager .
|
@techoner I believe Go implementation may have potential security problem. refer to: casbin/casbin-website#221 (comment). |
|
@Zxilly Please fix the conflict. |
|
@techoner working on this. A style PR make lots of conflict. |
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
Signed-off-by: Zxilly <zhouxinyu1001@gmail.com>
|
@techoner Plz review |
|
@Zxilly plz fix:
|
# [1.2.0](v1.1.3...v1.2.0) (2021-06-27) ### Features * add support for add_domain_matching_function ([#165](#165)) ([19b9503](19b9503))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
resolve: #161
Signed-off-by: Zxilly zhouxinyu1001@gmail.com