feat: add explicit priority support #190
Conversation
hsluoyz
requested review from
Zxilly and
leeqvip
and removed request for
Zxilly
casbin/model/policy.py
Outdated
| @@ -81,14 +83,39 @@ def has_policy(self, sec, ptype, rule): | |||
|
|
|||
| return rule in self[sec][ptype].policy | |||
|
|
|||
| def add_policy(self, sec, ptype, rule): | |||
| def add_policy(self, sec, ptype, rule) -> bool: | |||
There was a problem hiding this comment.
Maybe we don't need to think about type hint right now.
There was a problem hiding this comment.
Yeah but without type hint sometimes it's not easy to follow and regulate the program, especially for new developers.
Maybe we can add it later in a major release.
There was a problem hiding this comment.
@ffyuanda You can lead this style to the whole library in another PR.
There was a problem hiding this comment.
@Zxilly Sure we can do that
|
@ffyuanda plz fix:
|
Signed-off-by: ffyuanda <46557895+ffyuanda@users.noreply.github.com>
|
@techoner plz review |
|
@techoner updated load_policy() |
| except: | ||
|
|
||
| if self.auto_build_role_links and need_to_rebuild: | ||
| self.build_role_links() |
There was a problem hiding this comment.
@ffyuanda Here to throw the caught exception again.
There was a problem hiding this comment.
@techoner Just update, I catch the error and throw it after everything else.
Signed-off-by: ffyuanda <shaoxuan.yuan02@gmail.com>
# [1.9.0](v1.8.1...v1.9.0) (2021-09-25) ### Features * add explicit priority support ([#190](#190)) ([9445086](9445086))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Match with Casbin PR: #550 and #766
Signed-off-by: ffyuanda 46557895+ffyuanda@users.noreply.github.com