Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation off-by-one error #2547

Closed
SirNate0 opened this issue Oct 10, 2022 · 1 comment
Closed

Documentation off-by-one error #2547

SirNate0 opened this issue Oct 10, 2022 · 1 comment

Comments

@SirNate0
Copy link
Contributor

The documentation specifies that:

It is an error to specify a shard index greater than the number of shards.

However, the section it is in describes the shard index as starting at 0, so shouldn't this be greater than or equal to the number of shards?

https://github.com/catchorg/Catch2/blob/devel/docs/command-line.md#test-sharding

@horenmar
Copy link
Member

Hmmm, I guess the answer is yes. To be honest, it did not occur to me that someone could read it differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants