Vector Equals Matcher uses != for comparisons

[js-nano]

The vector Equals matcher uses != to compare elements:

Catch2/src/catch2/matchers/catch_matchers_vector.hpp

Line 91 in 584973a

if (m_comparator[i] != v[i])

I'd expect it to use == to compare elements (as implied by the Matcher's name 🙂)

Impacts are:

• Prior to C++20, an operator!= needs to be supplied for user types (in addition to operator==).
  • If you are using C++20, the situation is happier as your compiler can rewrite != to use operator== (provided your compiler supports P1185R2)
• If you're a monster and your operator== and operator!= are not the inverse of each other, the "wrong" operator would unexpectedly be used (again, based on the Matcher's name).

---

NB - In addition, != is used for approx matching here, though I don't think that would cause any of the issues noted above?

Catch2/src/catch2/matchers/catch_matchers_vector.hpp

Line 114 in 584973a

if (m_comparator[i] != approx(v[i]))

[horenmar]

I'll change this, but I have to say that in this case

If you're a monster and your operator== and operator!= are not the inverse of each other

it is the user's fault and I don't care.

[js-nano]

Thanks for this!

As regards

it is the user's fault and I don't care.

Yes, I agree completely!