Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatcherUntypedBase class has virtual functions, but destructor is not virtual #844

Closed
GatoRat opened this issue Mar 5, 2017 · 1 comment
Closed

MatcherUntypedBase class has virtual functions, but destructor is not virtual #844

GatoRat opened this issue Mar 5, 2017 · 1 comment

Comments

@GatoRat
Copy link

GatoRat commented Mar 5, 2017

Description

Compiling with Visual Studio 2017 RC and Visual Studio 2015 Update 3.
Treat specific warning as error: 4265

MatcherUntypedBase has virtual functions, but not a virtual destructor. Adding an empty virtual destructor fixes the issue.

  • Catch version: v1.8.1
  • Operating System: Windows 10
  • Compiler+version: VS 2015 and 2017
@philsquared
Copy link
Collaborator

Thanks for that. I've added that specific warning to the VS solution generation, too, now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philsquared @GatoRat