Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling for SHELL environment variable: #414

Closed
wants to merge 0 commits into from
Closed

Improve handling for SHELL environment variable: #414

wants to merge 0 commits into from

Conversation

apetrone
Copy link

@apetrone apetrone commented Dec 9, 2016

  • Use boolean conditional for checking shell_path to catch empty strings.

  • Throw an error if shell_path does not exist.

@wjwwood
Copy link
Member

wjwwood commented Jan 6, 2017

I tried to rebase this without closing it but something happened... I reopened as #421.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants