Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging on circular run depend. #440

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Fix hanging on circular run depend. #440

merged 2 commits into from
Mar 3, 2017

Conversation

mikepurvis
Copy link
Member

@mikepurvis mikepurvis commented Mar 3, 2017 •
edited
Loading

Add a new test for this, fixes #429, #439.

wjwwood
wjwwood approved these changes Mar 3, 2017
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit e30c226 into catkin:master Mar 3, 2017
@wjwwood
Copy link
Member

wjwwood commented Mar 3, 2017

Thanks @mikepurvis for the fix.

@wjwwood wjwwood mentioned this pull request Mar 3, 2017
Closed
4 tasks
@mikepurvis mikepurvis deleted the fix-dep-hang branch March 3, 2017 14:57
@mikepurvis mikepurvis mentioned this pull request Sep 24, 2018
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

catkin build hangs on circular run depdendency
2 participants
@mikepurvis @wjwwood