Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trollius to setup.py install_requires list #474

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Add trollius to setup.py install_requires list #474

merged 1 commit into from
Jul 16, 2017

Conversation

slivingston
Copy link
Contributor

closes issue #445
This patch can be viewed as continuing the work of pull request #282

@slivingston
Add trollius to setup.py install_requires list
f7af8ff 
closes catkin#445

This patch can be viewed as continuing the work of pull request catkin#282.
@slivingston
Copy link
Contributor Author

Note that the install context that leads to the error reported in #445 is not detected by the Travis CI configuration because trollius is explicitly installed on line 26 in the before_install clause of .travis.yml.

wjwwood
wjwwood approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I think this is now necessary since trollius was made optional by osrf_pycommon.

Thanks!

@wjwwood wjwwood merged commit fad6124 into catkin:master Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slivingston @wjwwood