Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect VERBOSE environment variable if already set before in verbose mode #506

Merged
merged 2 commits into from
Mar 12, 2018
Merged

Conversation

meyerj
Copy link
Contributor

@meyerj meyerj commented Feb 22, 2018

At the moment it is not possible to build a workspace with catkin_tools in verbose mode without also switching make to verbose mode.

For our continuous integration jobs I would like to have a way to see the normal output of cmake and make (with catkin build -v), but without all the clutter produced by make if the VERBOSE environment variable is set. The alternative is -i, but it does not behave well if the output is not a terminal and if multiple packages are built in parallel.

Note that setting VERBOSE=0 does not have the desired effect. The variable needs to be defined, but empty to disable make's verbosity (VERBOSE= catkin build -v ...).

Maybe the whole section was a leftover from debugging catkin_tools? The GitHub issue template explicitly asks to set VERBOSE=1 although -v already implies that in the current version:

[//]: # (Use `VERBOSE=1 catkin build -p1 -v` for verbose output)

@mikepurvis
Copy link
Member

The CI fail is due to flakiness on OS X that's unrelated to this change. Thanks for the contribution!

@mikepurvis mikepurvis merged commit 4ab4e25 into catkin:master Mar 12, 2018
@meyerj meyerj deleted the patch-1 branch March 12, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants