Force sphinxcontrib-spelling < 4.3.0 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-reynolds
force-pushed
the
fix-travis
branch
from
49ffde8
to
734db44
Compare
matthew-reynolds
force-pushed
the
fix-travis
branch
from
734db44
to
e66904f
Compare
|
Thanks very much for sorting this out! |
matthew-reynolds
added a commit
to matthew-reynolds/catkin_tools
that referenced
this pull request
Nov 14, 2019
Now that the project is only targetting python 3.5+, catkin#561 is no longer required and we can use the most up-to-date version of `sphinx` and `sphinxcontrib-spelling`.
Merged
mikepurvis
pushed a commit
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #559.
sphinxcontrib-spelling4.3.0 requires at leastsphinx2.0.0, which in turn requires at least Py3.5. Both Py2.7 and 3.4 are no longer supported as ofsphinx2.0.0, which causes the Travis build to fail during before_install.