respect setup.cfg during install #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeroyR
force-pushed
the
fix/bash_completion_install
branch
from
1bacbba
to
7781548
Compare
|
This seems like a reasonable change, but I don't know know enough about Python packaging to really feel confident that I understand the implications— in any case, I'm pretty sure the old slogans about " @wjwwood, do you mind weighing in here? |
I'm afraid I cannot say if this makes sense or not. I don't understand the use case or the actual technical problem. I'd say if it method that was failing now works and the related, "normal" method still works, then it's ok. |
|
Okay, merging. If there are howls of rage, it can be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installation fails if prefix is set with:
setup.py setopt -c "install" -o "prefix" -s "PREFIX"as the prefix for the bash_completion is only read from command line.
This fixes that by using distutils