Added option to past list of directories to list verb
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable. I'm assuming this going in means we also need to update the documentation referenced in the original ticket? |
|
Yes, documentation needs to be updated. Regardless of if this PR is accepted, there are a few instances where the documentation utilizes the Would it be helpful if I updated the docs on this PR? |
|
I'm fine to merge it now, and you can update the docs in a followup, particularly since the docs are already broken anyway— this change is not making anything worse. |
5 tasks
jarvisschultz
added a commit
to jarvisschultz/catkin_tools
that referenced
this pull request
Apr 30, 2020
- The `-d|--directory` feature was introduced in catkin#572 - Also ran `dump_cli` to update help literally included on verb documentation pages. This updated more than just `docs/verbs/cli/catkin_list.txt`, but they were in need of an update
mikepurvis
pushed a commit
that referenced
this pull request
May 22, 2020
) - The `-d|--directory` feature was introduced in #572 - Also ran `dump_cli` to update help literally included on verb documentation pages. This updated more than just `docs/verbs/cli/catkin_list.txt`, but they were in need of an update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential simple fix to address #571