Close #519 #575
Merged
Close #519 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, seems to work well. |
timonegk
added a commit
that referenced
this pull request
Feb 23, 2021
Merged
timonegk
added a commit
that referenced
this pull request
Feb 23, 2021
* fixup! argument parser: use None instead of [] for empty jobs args (#575) * add test that asserts that job flags do not disappear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #519 by using
Noneinstead of[]for empty jobs_args in the argument parser. When an empty list is used instead of None, the jobs args are removed when loading the context (https://github.com/catkin/catkin_tools/blob/master/catkin_tools/context.py#L207).