Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set posix=False when parsing environment variables #578

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Set posix=False when parsing environment variables #578

merged 1 commit into from
Nov 15, 2019

Conversation

timonegk
Copy link
Member

This pull request closes #528 by setting posix=False when parsing environment variables. This leads to a better handling of bash dollar-sign strings, e. g. $'\'\n' or $' \t\n"\'><;|&(:'.

@mikepurvis
Copy link
Member

Seems like a reasonable fix, thanks!

@mikepurvis mikepurvis merged commit 5b12126 into catkin:master Nov 15, 2019
@Rayman Rayman mentioned this pull request Nov 19, 2019
4 tasks
mikepurvis pushed a commit that referenced this pull request Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: No closing quotation
2 participants