-
-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(window): middle separator colors #369
Conversation
`middle_separator` is _not_ the same for fill `number` and `all`. For fill the colors are the same as text or color.
left_separator was _always_ overwritten in the `fill == number` branch.
This comment was marked as abuse.
This comment was marked as abuse.
Hey @pentago, I am sorry to hear that this PR has broken your configuration. However, comments in your tone are unacceptable and is in direct violation of our Code of Conduct (Points 2 and 4 to be exact.) If you find that a PR has broken your configuration or something looks unexpected as a result of an update, please raise a new issue clearly explaining what's wrong and what you think might be the root cause, without targeting the individuals in question. I won't accept these types of comments towards individuals who have kindly offered up their free time to help maintain this repository. I highly recommend that you pin your configuration to an existing GitHub tag to avoid unwanted and unexpected breakages. This is an official warning and if I see more comments in your tone (i.e. targeting individuals) then you will be blocked from this organisation. |
* fix(window): middle_separator `middle_separator` is _not_ the same for fill `number` and `all`. For fill the colors are the same as text or color. * chore(window): move left inside fill all branch left_separator was _always_ overwritten in the `fill == number` branch. Fixes catppuccin#353 --------- Co-authored-by: Kaley Main <kaleymain@google.com>
…uccin#371) This reverts commit c59df83.
middle_separator
is not the same for fillnumber
andall
, for fill the colors are the same as text or color (or the reverse of middle sep with number fill).before:
after:
Also changed where
@_ctp_w_left
is set since it was always overwritten when the fill is number.config
Fixes #353