Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window): middle separator colors #369

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

vdbe
Copy link
Contributor

@vdbe vdbe commented Oct 11, 2024

middle_separator is not the same for fill number and all, for fill the colors are the same as text or color (or the reverse of middle sep with number fill).

before:
image
after:
image

Also changed where @_ctp_w_left is set since it was always overwritten when the fill is number.

config
# Window
set -g @catppuccin_window_status_style "custom"
set -g window-status-separator ""

## Window global/default configuration
set -g @catppuccin_window_default_text "#{pane_title}"
set -g @catppuccin_window_status "icon"
set -g @catppuccin_window_default_fill "number"
set -g @catppuccin_window_number_position "left"

set -g @catppuccin_window_left_separator "█"
set -g @catppuccin_window_middle_separator "█ "
set -g @catppuccin_window_right_separator ""

## Window current configuration
set -g @catppuccin_window_current_text "#{pane_title}"
set -g @catppuccin_window_current_fill "all"
set -g @catppuccin_window_current_middle_separator " 󰿟 "

Fixes #353

vdbe added 2 commits October 11, 2024 08:45
`middle_separator` is _not_ the same for fill `number` and `all`.
For fill the colors are the same as text or color.
left_separator was _always_ overwritten in the `fill == number` branch.
@vdbe vdbe changed the title Fix/window/middle separator fix(window): middle separator Oct 11, 2024
@vdbe vdbe changed the title fix(window): middle separator fix(window): middle separator colors Oct 11, 2024
@kjnsn kjnsn merged commit c59df83 into catppuccin:main Oct 12, 2024
2 checks passed
@pentago

This comment was marked as abuse.

kjnsn added a commit that referenced this pull request Oct 12, 2024
kjnsn added a commit that referenced this pull request Oct 12, 2024
@sgoudham
Copy link
Contributor

Hey @pentago,

I am sorry to hear that this PR has broken your configuration. However, comments in your tone are unacceptable and is in direct violation of our Code of Conduct (Points 2 and 4 to be exact.)

If you find that a PR has broken your configuration or something looks unexpected as a result of an update, please raise a new issue clearly explaining what's wrong and what you think might be the root cause, without targeting the individuals in question. I won't accept these types of comments towards individuals who have kindly offered up their free time to help maintain this repository.

I highly recommend that you pin your configuration to an existing GitHub tag to avoid unwanted and unexpected breakages.

This is an official warning and if I see more comments in your tone (i.e. targeting individuals) then you will be blocked from this organisation.

pauldthomson pushed a commit to pauldthomson/tmux that referenced this pull request Nov 14, 2024
* fix(window): middle_separator

`middle_separator` is _not_ the same for fill `number` and `all`.
For fill the colors are the same as text or color.

* chore(window): move left inside fill all branch

left_separator was _always_ overwritten in the `fill == number` branch.

Fixes catppuccin#353

---------

Co-authored-by: Kaley Main <kaleymain@google.com>
pauldthomson pushed a commit to pauldthomson/tmux that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window_status_style 'slanted' and window_number_position 'right' create color bleeding.
4 participants