Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is jedis.get not wrapped in an effect? #639

Open
valzam opened this issue Jan 14, 2022 · 0 comments
Open

Why is jedis.get not wrapped in an effect? #639

valzam opened this issue Jan 14, 2022 · 0 comments

Comments

@valzam
Copy link

valzam commented Jan 14, 2022

Hey,

I've been looking at the redis cache implementation and noticed that compared to doPut and doRemove the implementation of doGet does not wrap calls to jedis in F.delay. Is there a specific reason for this?

https://github.com/cb372/scalacache/blob/master/modules/redis/src/main/scala/scalacache/redis/RedisCacheBase.scala#L48

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant