Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update binary parser to nom 5 #6

Closed
cbourjau opened this issue Jun 30, 2019 · 1 comment
Closed

Update binary parser to nom 5 #6

cbourjau opened this issue Jun 30, 2019 · 1 comment
Labels
help wanted mentor Mentoring available

Comments

@cbourjau
Copy link
Owner

Currently, the underlying binary parser is implemented using the nom 3 create. At the time of writing, the latest version of nom is 5. The latest nom release makes it possible to use functions instead of macros. This is nice for many reasons but primarily:

  • Simpler to understand
  • Better compile times
  • Better IDE/clippy/rustfmt support
  • Potentially better performance

Furthermore, rewriting the parsers is a good way of getting to know this project better! There has been a previous attempt at this (for nom 4) but the PR has become stale (#5).
@cbourjau cbourjau added help wanted mentor Mentoring available labels Jun 30, 2019
@cbourjau
Copy link
Owner Author

Fixed in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted mentor Mentoring available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbourjau