Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add auto-watch based on regex #2361

Closed
YfheA3r opened this issue Jul 15, 2019 · 3 comments
Closed

[Feature Request] Add auto-watch based on regex #2361

YfheA3r opened this issue Jul 15, 2019 · 3 comments

Comments

@YfheA3r
Copy link

YfheA3r commented Jul 15, 2019

It whould be nice to have something similar to the filter system but that instead of hiding the thread it add it to the watcher

@YfheA3r
Copy link
Author

YfheA3r commented Jul 16, 2019

I tried to implement it:
https://github.com/YfheA3r/4chan-x/commit/e886f590da493697fc9b4cf9c6c403ac6e21252c
Since i don't really know CoffeeScript for the most part i just copy pasted code from the filtering system

It does work but there are problems that i'm not able to resolve:
-It doesn't remove auto-watched threads when you remove the regex
-It test the regex agains every post instead of every thread

@ccd0
Copy link
Owner

ccd0 commented Jul 16, 2019

Copypasting huge chunks of code like that is bad design. Instead you should edit the Filter feature to add this. You could indicate that a filter should watch rather than hide a thread by adding ";watch" to the end, like is already done with ";highlight" and ";notify".

@ccd0
Copy link
Owner

ccd0 commented Jul 16, 2019

Also, this is a duplicate of #1471 so further discussion should go there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants