Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL History Search #654

Open
laurentpetit opened this issue Mar 16, 2015 · 12 comments
Open

REPL History Search #654

laurentpetit opened this issue Mar 16, 2015 · 12 comments
Assignees
Milestone

Comments

@laurentpetit
Copy link
Member

Original issue 613 created by laurentpetit on 2014-01-27T10:05:06.000Z:

Additional to stepping through the REPL history, a search through history is important for every day work.

My attempt to implement this similar to the search in bash or in repl-y (https://github.com/trptcolin/reply) was not integrated (issue # 322).
Maybe a different implementation approach to searching the REPL history might be better but we need to have some possibility to search the REPL history together with settings to adjust the history size stored.

I set this issue to high priority since the absence of a REPL search annoys me multiple times per day.
Sadly, I have no time anymore to build this feature on my own this year. :(

@laurentpetit
Copy link
Member Author

Comment #1 originally posted by laurentpetit on 2014-01-27T10:06:12.000Z:

Sorry, I meant issue # 332.

@laurentpetit
Copy link
Member Author

Comment #2 originally posted by laurentpetit on 2014-05-22T08:22:10.000Z:

Issue 332 has been merged into this issue.

@laurentpetit
Copy link
Member Author

Comment #3 originally posted by laurentpetit on 2014-05-22T08:32:03.000Z:

The outdated pull request which implemented a pretty simple REPL search can be found here:
#19

@laurentpetit
Copy link
Member Author

Comment #4 originally posted by laurentpetit on 2014-05-22T09:26:34.000Z:

Issue 332 has been merged into this issue.

@laurentpetit
Copy link
Member Author

Comment #5 originally posted by laurentpetit on 2014-05-22T09:27:05.000Z:

<empty>

@laurentpetit
Copy link
Member Author

Comment #6 originally posted by laurentpetit on 2014-06-26T20:22:20.000Z:

<empty>

@laurentpetit
Copy link
Member Author

Comment #7 originally posted by laurentpetit on 2014-07-10T20:10:22.000Z:

<empty>

@laurentpetit
Copy link
Member Author

Comment #8 originally posted by laurentpetit on 2014-09-25T21:28:44.000Z:

<empty>

@laurentpetit laurentpetit modified the milestone: next Mar 22, 2015
@guv
Copy link

guv commented Jun 8, 2015

I am still missing the REPL search feature badly. Are there any attempts to implement something like that?

@laurentpetit
Copy link
Member Author

I'm sooo sorry to have delayed finalizing your work for so long. Private things..
I'm willing to take this further and work on it.

Maybe you could help by trying to revive your PR #19 by making it in a megeable state? You can rewrite its history if you want, rebase it on top of master as well. I've not worked on it locally yet.

Even if you find out it's too much work to rebase/revive this PR, this will be an interesting knowledge.

What about that?

@guv
Copy link

guv commented Jun 17, 2015

I am not sure whether I'll have any time at all for that. :-/

@laurentpetit
Copy link
Member Author

Ok, good to know, will include it in the Todo list anyway

@laurentpetit laurentpetit modified the milestones: 0.33.0, next, 0.34.0 Jul 30, 2015
@laurentpetit laurentpetit modified the milestones: 0.34.0, next Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants