Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin cash (BCC vs BCH) #83

Closed
marinsokol5 opened this issue Aug 2, 2017 · 14 comments
Closed

Bitcoin cash (BCC vs BCH) #83

marinsokol5 opened this issue Aug 2, 2017 · 14 comments
Assignees

Comments

@marinsokol5
Copy link

As all of you are well aware there is a new currency in the game by the name of Bitcoin Cash.
https://coinmarketcap.com/currencies/bitcoin-cash/

I manually checked a lot of exchanges and those that do have it, are calling it either BCH or BCC.
I propose that ccxt's default simbol for Bitcoin Cash should be BCH becouse BCC is used already by
https://coinmarketcap.com/currencies/bitconnect/.

That being said I can't seem to think of a way of doing this but manully checking which exhange is calling it BCC and then switching the value upon call BCH->BCC so that we can still call it BCH.

I suggest putting an enhancement label on this and waiting for 10 days or maybe two weeks.
A lot of people think that the currency might be dumped by everyone ant that her value will be next no nothing.
I am not a prophet but what i do know is that if it survives the first 2 weeks than it's here to stay and we should adapt to it.

@kroitor
Copy link
Member

kroitor commented Aug 2, 2017

Thanks for this very important notice!

@kroitor kroitor self-assigned this Aug 2, 2017
@kroitor kroitor changed the title Bitcoin cash Bitcoin cash (BCC vs BCH) Aug 2, 2017
@kroitor
Copy link
Member

kroitor commented Aug 4, 2017

Received this from GDAX/Coinbase. They say, they will support it... in January 2018.

From: no-reply@updates.coinbase.com

Dear Coinbase customer, 

...

Over the last several days, we’ve examined all of the relevant issues and have
decided to work on adding support for bitcoin cash for Coinbase customers. 
We made this decision based on factors such as the security of the network, 
customer demand, trading volumes, and regulatory considerations.

We are planning to have support for bitcoin cash by January 1, 2018, assuming 
no additional risks emerge during that time.

Once supported, customers will be able to withdraw bitcoin cash. We'll make a 
determination at a later date about adding trading support. In the meantime, 
customer bitcoin cash will remain safely stored on Coinbase.

Thank you,

Coinbase Team

kroitor added a commit that referenced this issue Aug 6, 2017
@kroitor
Copy link
Member

kroitor commented Aug 7, 2017

As part of our investigation )

Red = unreachable
Yellow = may be confusing BCC with BCH
Green = good (no confusion)

We will upload fixes for all yellow ones )

screen shot 2017-08-07 at 19 40 05

kroitor added a commit that referenced this issue Aug 7, 2017
kroitor added a commit that referenced this issue Aug 7, 2017
kroitor added a commit that referenced this issue Aug 7, 2017
kroitor added a commit that referenced this issue Aug 7, 2017
kroitor added a commit that referenced this issue Aug 7, 2017
kroitor added a commit that referenced this issue Aug 7, 2017
@kroitor
Copy link
Member

kroitor commented Aug 7, 2017

Yobit also has BBCC – BaseballCard %)

kroitor added a commit that referenced this issue Aug 7, 2017
kroitor added a commit that referenced this issue Aug 7, 2017
@kroitor
Copy link
Member

kroitor commented Aug 7, 2017

screen shot 2017-08-07 at 20 38 52

@kroitor
Copy link
Member

kroitor commented Aug 7, 2017

Before:

id            | BCC           | BCH          
---------------------------------------------
_1broker      |               |              
_1btcxe       |               |              
anxpro        |               |              
bit2c         |               |              
bitbay        |               |              
bitbays       |               |              
bitcoincoid   |               |              
bitfinex      | bitfinex      | bitfinex     
bitflyer      |               | bitflyer     
bitlish       |               |              
bitmarket     |               |              
bitmex        |               |              
bitso         |               | bitso        
bitstamp      |               |              
bittrex       | bittrex       |              
bl3p          |               |              
btcchina      |               |              
btce          |               |              
btcexchange   |               |              
btctradeua    |               |              
btcturk       |               |              
btcx          |               |              
bter          | bter          |              
bxinth        |               |              
ccex          |               |              
cex           |               | cex          
chbtc         |               |              
chilebit      |               |              
coincheck     |               |              
coingi        |               |              
coinmarketcap | coinmarketcap | coinmarketcap
coinmate      |               |              
coinsecure    |               |              
coinspot      |               |              
dsx           |               |              
exmo          |               |              
flowbtc       |               |              
foxbit        |               |              
fybse         |               |              
fybsg         |               |              
gatecoin      |               | gatecoin     
gdax          |               |              
gemini        |               |              
hitbtc        | hitbtc        |              
huobi         |               |              
itbit         |               |              
jubi          | jubi          |              
kraken        |               | kraken       
lakebtc       |               |              
livecoin      | livecoin      | livecoin     
liqui         | liqui         |              
luno          |               |              
mercado       |               |              
okcoincny     |               |              
okcoinusd     |               |              
paymium       |               |              
poloniex      |               |              
quadrigacx    |               |              
quoine        |               | quoine       
southxchange  |               |              
surbitcoin    |               |              
therock       |               | therock      
urdubit       |               |              
vaultoro      |               |              
vbtc          |               |              
virwox        |               |              
xbtce         |               |              
yobit         | yobit         |              
yunbi         | yunbi         |              
zaif          |               |              

@kroitor
Copy link
Member

kroitor commented Aug 7, 2017

After:

id            | BCC           | BCH          
---------------------------------------------
_1broker      |               |              
_1btcxe       |               |              
anxpro        |               |              
bit2c         |               |              
bitbay        |               |              
bitbays       |               |              
bitcoincoid   |               |              
bitfinex      | bitfinex      | bitfinex     
bitflyer      |               | bitflyer     
bitlish       |               |              
bitmarket     |               |              
bitmex        |               |              
bitso         |               | bitso        
bitstamp      |               |              
bittrex       |               | bittrex      
bl3p          |               |              
btcchina      |               |              
btce          |               |              
btcexchange   |               |              
btctradeua    |               |              
btcturk       |               |              
btcx          |               |              
bter          |               | bter         
bxinth        |               |              
ccex          |               |              
cex           |               | cex          
chbtc         |               |              
chilebit      |               |              
coincheck     |               |              
coingi        |               |              
coinmarketcap | coinmarketcap | coinmarketcap
coinmate      |               |              
coinsecure    |               |              
coinspot      |               |              
dsx           |               |              
exmo          |               |              
flowbtc       |               |              
foxbit        |               |              
fybse         |               |              
fybsg         |               |              
gatecoin      |               | gatecoin     
gdax          |               |              
gemini        |               |              
hitbtc        |               | hitbtc       
huobi         |               |              
itbit         |               |              
jubi          |               | jubi         
kraken        |               | kraken       
lakebtc       |               |              
livecoin      | livecoin      | livecoin     
liqui         |               | liqui        
luno          |               |              
mercado       |               |              
okcoincny     |               |              
okcoinusd     |               |              
paymium       |               |              
poloniex      |               |              
quadrigacx    |               |              
quoine        |               | quoine       
southxchange  |               |              
surbitcoin    |               |              
therock       |               | therock      
urdubit       |               |              
vaultoro      |               |              
vbtc          |               |              
virwox        |               |              
xbtce         |               |              
yobit         |               | yobit        
yunbi         |               | yunbi        
zaif          |               |              

@marinsokol5
Copy link
Author

Long time no see.
There seems to be still an BCC issue with bter.
Try calling:

bter = ccxt.bter()
print(bter.fetch_tickers())

It throws :

  File "/home/marin/fino/.venv/lib/python3.6/site-packages/ccxt/__init__.py", line 5344, in fetch_tickers
    market = self.markets[symbol]
KeyError: 'BCC/CNY'

@kroitor
Copy link
Member

kroitor commented Aug 14, 2017

Hi! Good to hear again from you! Thanks for reporting! I will fix this, of course (probably very soon).

kroitor added a commit that referenced this issue Aug 15, 2017
kroitor added a commit that referenced this issue Aug 15, 2017
@kroitor
Copy link
Member

kroitor commented Aug 15, 2017

This issue with BCC vs BCH on Bter should be fixed now! Thx again!

@kroitor
Copy link
Member

kroitor commented Aug 15, 2017

The fix is available in v.1.3.86. Best wishes!

@marinsokol5
Copy link
Author

marinsokol5 commented Aug 15, 2017

Thank you but now it throws error on QTUM/ETH.

  File "/home/marin/fino/.venv/lib/python3.6/site-packages/ccxt/__init__.py", line 5362, in fetch_tickers
    market = self.markets[symbol]
KeyError: 'QTUM/ETH'

Call method fetch_tickers() on bter.

@kroitor
Copy link
Member

kroitor commented Aug 15, 2017

Hmmm... I'm not getting this on testing. But I'll fix it anyway, thanks for feedback! Will upload a fix soon.

@kroitor
Copy link
Member

kroitor commented Aug 20, 2017

BCH vs BTC Hashrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants