kuna exchange added

[mkutny]

No description provided.

[kroitor]

Hi, @mkutny ! Thx for the PR! We will merge it! But, unfortunately, Travis and GitHub are having troubles at the moment, so, I guess, we'll have to wait until they resolve (usually should not take more than a few hours). Just letting you know! Thx again!

[kroitor]

Ah, unfortunately it fails on Python, because result[currency] is illegal in Python if result does not have such key (throws a KeyError exception)... This is why i had to rewrite that extend into an if () {} else {}... But don't bother, I'll fix for that, it's just a Python-only issue and you didn't have to know that. No worries.

[kroitor]

Ok, I merged it and it should be available as of v1.9.169+! Respect and thanks a lot for your efforts!

[mkutny]

@kroitor,

Just curious, why did you decide to re-implement sign() in kuna class? Order management worked with sign() in acx class as well.

And as a side note: actually, I wanted to start small with just one market, test it thoroughly and then extend to other markets but I see you already added them. I noticed few bugs there so will send a new PR later on today.

[kroitor]

@mkutny

Just curious, why did you decide to re-implement sign() in kuna class? Order management worked with sign() in acx class as well.

There's a very slight difference in their endpoint URLs (at least that is what I was observing on my side). ACX and Yunbi do add .json extension to their endpoints, whereas Kuna does not. Because of that I had some failures on public methods. But apart from that everything else is the same. Of course, I should've refactored it into a configurable extension property and keep a single method using that property instead. But that copy-paste does it as a quickfix (temporarily). I'm sure we will eventually bring it back to a unified sign(), hopefully, very soon.

To reproduce those mentioned pubic API failures, remove that sign() method from Kuna and run:
node test/test kuna or node test/test --verbose kuna.

Looking forward to see more commits from you! Thx again!

[kroitor]

@mkutny, ok, somewhat better now )