Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find Nullable #80

Closed
choweiyuan opened this issue Jan 20, 2020 · 3 comments · Fixed by #84
Closed

Can't find Nullable #80

choweiyuan opened this issue Jan 20, 2020 · 3 comments · Fixed by #84
Assignees

Comments

@choweiyuan
Copy link
Contributor

choweiyuan commented Jan 20, 2020

Expected Behavior

Current Behavior

Might be a developer thing, I can't run tests locally without javax.annotation.Nullable

Context

Steps to Reproduce (for bugs)

#77 's fix Artifact.java seems to be using
import javax.annotation.Nullable;

image

which probably doesn't exist by default, have to include a separate jar for this.
https://stackoverflow.com/questions/19030954/cant-find-nullable-inside-javax-annotation

Throughout the project, org.jclouds.javax.annotation.Nullable is used instead.

Your Environment

IntelliJ IDEA 2019.3.1

@martinda
Copy link
Collaborator

@choweiyuan Try building from the command line: ./gradlew build. Also check your Java version.

@choweiyuan
Copy link
Contributor Author

Okay that worked. But is that the right package to be used for Nullable
If you're fine with javax.annotation.Nullable rather than org.jclouds.javax.annotation.Nullable I'm happy to close this

@cdancy
Copy link
Owner

cdancy commented Jan 21, 2020

@choweiyuan to side-step these problems we should use the jclouds version as newer releases of the JDK have this in a separate artifact. We could search through our code and remove/replace if someone is up for it. Any takers? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants