Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI job to run unit tests #2

Closed
afrittoli opened this issue Aug 17, 2022 · 7 comments
Closed

Setup CI job to run unit tests #2

afrittoli opened this issue Aug 17, 2022 · 7 comments

Comments

@afrittoli
Copy link
Contributor

afrittoli commented Aug 17, 2022

Using GitHub actions, setup a CI job to run unit tests against all PRs and one CI job for linting.

The repo includes a makefile with targets already defined for that:

$ make
Makefile      all           fmt           get-fmt-deps  importfmt     lint          test
This was referenced Sep 1, 2022
@bradmccoydev
Copy link
Member

@afrittoli I have created this GitHub Action please see the pull request #16

@e-backmark-ericsson
Copy link

Should we bring this PR from sig-events into this issue, or should it be a separate issue to actually implement some unit tests for the Go SDK?

@bradmccoydev
Copy link
Member

Sounds good to me @e-backmark-ericsson

@afrittoli
Copy link
Contributor Author

The test in the new SDK already provide coverage for the new code base.

@e-backmark-ericsson
Copy link

Closing this issue in accordance with above comment

@e-backmark-ericsson
Copy link

Sorry, closed this issue by mistake. Should have closed the mentioned PR in sig-events instead. Fixed that now.

@afrittoli
Copy link
Contributor Author

This is actually closed, thanks @bradmccoydev for adding the CI jobs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants