Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems processing some files with complex paths #505

Closed
mrdav1 opened this issue Jun 29, 2023 · 6 comments
Closed

Problems processing some files with complex paths #505

mrdav1 opened this issue Jun 29, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@mrdav1
Copy link

mrdav1 commented Jun 29, 2023

FastFlix Version: 5.5.6

Operating System: Windows 10 x64

Describe the bug
Unable to burn-in subtitles for files with complex path

To Reproduce
Add media with complex file path
Enable burn-in for subtitles

Logs
flix_conversion_01 Final Call (2160p HD)_2023-06-29T15.36.44.log
@mrdav1 mrdav1 added the bug Something isn't working label Jun 29, 2023
@mrdav1
Copy link
Author

mrdav1 commented Jun 29, 2023

Just remembered that this is very similar to an old bug I reported (#350)

@cdgriffith
Copy link
Owner

What I'm confused about is there is somehow a space after the drive letter, which...can't be there

-filter_complex "[0:0]subtitles='D\ :\\Users\\Maddie\\...

I think if it's removed so it's D\:\\ instead it should work, but I honestly don't know how it got to that point to start with (somehow in FastFlix, not something you did). Looking at it but is tricky

@mrdav1
Copy link
Author

mrdav1 commented Jul 18, 2023 via email •
edited
Loading

@mrdav1
Copy link
Author

mrdav1 commented Oct 4, 2023 •
edited
Loading

Just discovered that this problem is not limited to subtitles. If seems that any pathname with "\\" qualifiers that that "wrap" across lines is affected.

For example:

D\:
\\PathName\\File

Becomes "D: \PathName\File" (which equates to "D: \PathName\File" during processing.

This happens frequently.

@mrdav1 mrdav1 changed the title Unable To Burn-In Subtitles Problems processing some files with complex paths Oct 4, 2023
cdgriffith added a commit that referenced this issue Feb 23, 2024
@cdgriffith
* Fixing #543 systems with more than one opencl device would break th…
36ad9db 
…umbnails and some encodings (thanks to swadomlic)

* Fixing #505 (maybe) trying new methods to clean file paths for subtitles (thanks to Maddie Davis)
@mrdav1
Copy link
Author

mrdav1 commented Mar 3, 2024

I think that I've found the "Perfect Storm" that causes the issue...

1: Pathname is long and contains sub-directories
2: Pathname has "\" qualifiers that that "wrap" across lines
3: Usually HDR10+ source (but not always)

This happens frequently when the queue is saved and re-loaded.

I hope this is of some help.

@cdgriffith cdgriffith mentioned this issue Apr 17, 2024
Merged
cdgriffith added a commit that referenced this issue Jun 16, 2024
@cdgriffith
Version 5.7.0 (#551)
07fc0c7 
* Adding new audio encoding panel
* Adding support for audio quality targeting instead of bitrate
* Fixing that audio and subtitles would be reset on change of encoder
* Fixing #543 systems with more than one opencl device would break thumbnails and some encodings (thanks to swadomlic)
* Fixing #505 (maybe) trying new methods to clean file paths for subtitles (thanks to Maddie Davis)
@cdgriffith
Copy link
Owner

Hopefully this issue has been resolved as of the 5.7.X versions? If not please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @mrdav1