Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add module info #37

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

dizney
Copy link
Contributor

@dizney dizney commented Oct 6, 2022

  • add moditect maven plugin to generate module-info.java, which excludes the internal package from exporting
  • updated example project to use newer maven compiler which supports modules, and add a module-info.java to require the dotenv module

Resolves #20

- add moditect maven plugin to generate module-info.java, which excludes the internal package from exporting
- updated example project to use newer maven compiler which supports modules, and add a module-info.java to require the dotenv module
@dizney
Copy link
Contributor Author

dizney commented Oct 6, 2022

I used io.github.cdimascio.dotenv.java as module name which might be up for debate. I mainly added the .java to differentiate it from the dotenv-kotlin module/package.

@cdimascio cdimascio merged commit f69a9b3 into cdimascio:master Nov 23, 2022
@cdimascio
Copy link
Owner

@all-contributors add @dizney for code and doc

@allcontributors
Copy link
Contributor

@cdimascio

I've put up a pull request to add @dizney! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add module-info to the project
2 participants