fix: ACL not compatible with Owernship Controls

[bryan-robitaille]

Summary | Résumé

Removes the "private" acl block as it is not compatible with Enforced Bucket Ownership.

[github-actions]

⚠ Terrform update available

Terragrunt: 0.54.12 (using 0.54.8)

[github-actions]

Staging: pr_review

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 4 to change, 0 to destroy

Show summary

CHANGE	NAME
update	aws_ecr_repository.pr_review_repository[0]
	aws_iam_policy.forms_lambda_parameter_store[0]
	aws_iam_role.forms_lambda_client[0]
	aws_security_group.lambda_client_pr_review[0]

Show plan

Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_ecr_repository.pr_review_repository[0] will be updated in-place
  ~ resource "aws_ecr_repository" "pr_review_repository" {
        id                   = "pr_review"
        name                 = "pr_review"
      ~ tags                 = {
          - "CostCentre" = "forms-platform-staging" -> null
          - "Terraform"  = "true" -> null
        }
        # (5 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

  # aws_iam_policy.forms_lambda_parameter_store[0] will be updated in-place
  ~ resource "aws_iam_policy" "forms_lambda_parameter_store" {
        id        = "arn:aws:iam::687401027353:policy/formsLambdaParameterStoreRetrieval"
        name      = "formsLambdaParameterStoreRetrieval"
      ~ tags      = {
          - "CostCentre" = "forms-platform-staging" -> null
          - "Terraform"  = "true" -> null
        }
        # (5 unchanged attributes hidden)
    }

  # aws_iam_role.forms_lambda_client[0] will be updated in-place
  ~ resource "aws_iam_role" "forms_lambda_client" {
        id                    = "forms-lambda-client"
        name                  = "forms-lambda-client"
      ~ tags                  = {
          - "CostCentre" = "forms-platform-staging" -> null
          - "Terraform"  = "true" -> null
        }
        # (9 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # aws_security_group.lambda_client_pr_review[0] will be updated in-place
  ~ resource "aws_security_group" "lambda_client_pr_review" {
        id                     = "sg-0554e1d0a9da92168"
        name                   = "lambda-admin-pr-review"
      ~ tags                   = {
          - "CostCentre" = "forms-platform-staging" -> null
        }
      ~ tags_all               = {
          + "Terraform"  = "true"
            # (1 unchanged element hidden)
        }
        # (7 unchanged attributes hidden)
    }

Plan: 0 to add, 4 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_ecr_repository.pr_review_repository[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_policy.forms_lambda_parameter_store[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_iam_role.forms_lambda_client[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_security_group.lambda_client_pr_review[0]"]

23 tests, 19 passed, 4 warnings, 0 failures, 0 exceptions