Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Errors showing up in server logs #3580

Closed
1 task
bryan-robitaille opened this issue May 9, 2024 · 1 comment · Fixed by #3659
Closed
1 task

Action Errors showing up in server logs #3580

bryan-robitaille opened this issue May 9, 2024 · 1 comment · Fixed by #3659
Assignees

Comments

@bryan-robitaille
Copy link
Contributor

bryan-robitaille commented May 9, 2024

Part of the amazing workings of Server Actions is that the server error is transmitted back to the client browser where it can be handled or caught by the Error Boundary.

The issue is that even through the error is handled client side the unhandled server error is printed to server console which is caught by our system monitoring and raises an alarm in slack.

Screenshot 2024-05-09 at 9.12.59 AM.png

Server Browser
Screenshot 2024-05-08 at 3.30.34 PM.png Screenshot 2024-05-08 at 3.30.23 PM.png

We should ensure that when and action is expected to throw an error, for example deleting a form that has existing responses, that the errro is handled server side and transmitted in a safe fashion to the client to activate the corresponding toasts.

Acceptance Criteria:

  • All Server Actions are reviewed and updated to ensure that all actions that throw errors are transitioned to instead send the error message through a property back to the client.
@srtalbot
Copy link
Contributor

Out of scope: client-side handling, app team will be focusing on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants