fix: Add file extention check into single middleware matcher. #3870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
The current middleware was behaving unexpectedly with the current matcher array. The documentation was not clear that the array represents a logical OR between matchers and not a logical AND. The matchers were originally seperated for readability but have now been combined to ensure proper functionality.
Discovered because
favicon.ico
was having a language parameter added to it's path by the middleware which in turn caused the browser to receive a 404 when requesting the redirected path.Test instructions | Instructions pour tester la modification
Pull Request Checklist
Please complete the following items in the checklist before you request a review: