feat: live message #3876
Merged
feat: live message #3876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://ymfux7g6cmzkuhslbfmlyxwdsa0afyak.lambda-url.ca-central-1.on.aws/ |
timarney
reviewed
Jun 21, 2024
...ms)/[locale]/(form administration)/form-builder/components/shared/right-panel/RightPanel.tsx
Outdated
Show resolved
Hide resolved
timarney
reviewed
Jun 21, 2024
timarney
reviewed
Jun 24, 2024
| @@ -836,7 +836,8 @@ | |||
| "translation": "Traductions", | |||
| "treeView": { | |||
| "addSection": "Nouvelle section" | |||
| } | |||
| }, | |||
| "loadTab": "[FR]Loaded {{tabPanelLabel}} editor" | |||
There was a problem hiding this comment.
@anikbrazeau small new translation string here
:)
anikbrazeau
reviewed
Jun 24, 2024
Co-authored-by: Anik Brazeau <38330843+anikbrazeau@users.noreply.github.com>
timarney
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR adds a global client util send a message that will be announced in a live-region. This solves the immediate problem with the logic panel not announcing updates when a panel is updated by server action updating a route. This will solve similar cases in the future.
Before using the LiveMessage util
Screen.Recording.2024-06-21.at.11.35.15.AM.mov
Afterusing the LiveMessage util
Screen.Recording.2024-06-21.at.11.36.10.AM.mov