Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure modal for conditional rules starts with option selected #4178

Merged
merged 8 commits into from
Aug 21, 2024
Merged

fix: ensure modal for conditional rules starts with option selected #4178

merged 8 commits into from
Aug 21, 2024

Conversation

timarney
Copy link
Member

@timarney timarney commented Aug 8, 2024 •
edited
Loading

Summary | Résumé

  • Adds mode for the modal dialog add or edit.
  • Adds a rule based on the option that was click for add a rule when in add mode

fixes: #4076

Kapture.2024-08-08.at.14.44.29.mp4

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

🧪 Review environment

https://ospdrzlxypn5ik7pngz7ywvssa0uqelm.lambda-url.ca-central-1.on.aws/

@timarney timarney marked this pull request as ready for review August 9, 2024 12:14
@thiessenp-cds thiessenp-cds enabled auto-merge (squash) August 21, 2024 12:26
@thiessenp-cds thiessenp-cds merged commit afcee50 into develop Aug 21, 2024
13 checks passed
@thiessenp-cds thiessenp-cds deleted the rules-create-starter-rule branch August 21, 2024 12:32
@sre-read-write sre-read-write bot mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsamojlenko dsamojlenko dsamojlenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepopulate selected option when adding a rule, rather than needing to reselect option in modal
3 participants
@timarney @dsamojlenko @thiessenp-cds