Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust next action choice rules when option removed #4180

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

timarney
Copy link
Member

@timarney timarney commented Aug 8, 2024

Summary | Résumé

Adds code and utility functions to decrement next actions when an option is removed.

Fixes: #4169

Testing:
adjust-rules-form.json

With the attached file
Go to branching --- look at the rules
Option A -> Page A
Option B -> Page B
Option C -> Page C
Option D -> Page D

--

Delete option B

Branching should keep the existing rules - the B option rule

Kapture.2024-08-08.at.12.24.35.mp4

Original code in #4170 --- started fresh PR after squash merge caused conflicts.

@timarney timarney marked this pull request as ready for review August 8, 2024 16:12
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM :)

@timarney timarney enabled auto-merge (squash) August 8, 2024 17:59
@timarney timarney merged commit da5f70f into develop Aug 8, 2024
13 checks passed
@timarney timarney deleted the adjust-choice-rules-1 branch August 8, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing an option that has a branching rule attached to it breaks the branching rules
3 participants