Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updates Repeating Sets, Pages and Rules to work together on the Review page and form output #4186

Merged
merged 30 commits into from
Aug 16, 2024

Conversation

thiessenp-cds
Copy link
Contributor

@thiessenp-cds thiessenp-cds commented Aug 9, 2024

Summary | Résumé

Updates the Review page, both in Preview and Forms-form mode, to work with Repeating Sets.

The main areas to test are:

  • Form-builder Preview: the review page and form response outputs (HTML, CSV, JSON)
  • Forms-form: the review page and form response outputs (HTML, CSV, JSON)

Copy link
Contributor

github-actions bot commented Aug 9, 2024

@thiessenp-cds thiessenp-cds changed the title feat: Updates Review to handle Repeating Sets (Sub Elements) feat: Updates Repeating Sets, Pages and Rules to work together on the Review page and form output Aug 13, 2024
@thiessenp-cds thiessenp-cds marked this pull request as ready for review August 15, 2024 11:26
ShadeWyrm
ShadeWyrm previously approved these changes Aug 15, 2024
Copy link
Contributor

@ShadeWyrm ShadeWyrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to work!~

dsamojlenko
dsamojlenko previously approved these changes Aug 15, 2024
Copy link
Member

@dsamojlenko dsamojlenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiessenp-cds thiessenp-cds merged commit 5422d6c into develop Aug 16, 2024
13 checks passed
@thiessenp-cds thiessenp-cds deleted the feat/4166 branch August 16, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants