-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multiple fileInputs in a repeatingSet #4188
Conversation
🧪 Review environmenthttps://7y4fhanloyl5llyhznpxlujqki0pyyxw.lambda-url.ca-central-1.on.aws/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, I think this code could really help readability if it were refactored. Especially the deep nesting, including nested try-catches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in the Preview mode and forms-form mode with files under and over the combined 5MB limit, works as expected. This code also looks pretty isolated so a full app test probably isn't necessary (beyond the happy paths)
Nice work, LGTM :)
Summary | Résumé
Fixes multiple fileInputs in a repeatingSet.
Previously, if you attempted to attach more than one file in a repeatingSet you would see the following error in the console and the form submit would fail:
Additionally, through testing it appears we'll need to set the maximum total file size lower to accommodate payload limits when sending to Notify. Dropped the overall bodySizeLimit for serverActions to 5MB, meaning the file size limit is actually about 4MB.
Test instructions