Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support redis cluster transport #2204

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

zs-neo
Copy link

@zs-neo zs-neo commented Dec 10, 2024

Attempt to address #1021

Thank you very much for your code, it helps us a lot. @auvipy

We use redis-py instead of redis-py-cluster because redis-py-cluster has been merged into redis-py.
Celery works fine on our cluster with multi producers and multi consumers, when a node goes down, it can automatically switch.

celery==5.4.0
Django==4.1
django-celery-beat==2.7.0
django-celery-results==2.5.1
django-filter==24.3
django-redis==5.4.0
django-split-settings==0.3.0
django-timezone-field==5.1
djangorestframework==3.15.2
gunicorn==22.0.0
pyOpenSSL==21.0.0
redis==5.0.0
requests==2.22.0
uWSGI==2.0.18
app = Celery('celery_test', broker='rediscluster://:myredis@127.0.0.1:7024')

@Nusnus Nusnus self-requested a review December 10, 2024 13:52
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 67.87565% with 62 lines in your changes missing coverage. Please review.

Project coverage is 81.22%. Comparing base (1220144) to head (b4405fa).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
kombu/transport/rediscluster.py 67.70% 45 Missing and 17 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2204      +/-   ##
==========================================
- Coverage   81.49%   81.22%   -0.28%     
==========================================
  Files          77       78       +1     
  Lines        9509     9702     +193     
  Branches     1148     1187      +39     
==========================================
+ Hits         7749     7880     +131     
- Misses       1569     1614      +45     
- Partials      191      208      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zs-neo zs-neo marked this pull request as draft December 13, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant