Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork DAGStore and extended ShardAccessor to return an io.Reader #1101

Closed
Tracked by #1099
Wondertan opened this issue Sep 15, 2022 · 3 comments
Closed
Tracked by #1099

Fork DAGStore and extended ShardAccessor to return an io.Reader #1101

Wondertan opened this issue Sep 15, 2022 · 3 comments
Assignees
@distractedm1nd
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Wondertan commented Sep 15, 2022 •
edited
Loading

According to #1099, the DAGStore.ShardAccessor has to return an io.Reader. Unfortunately, it does not do so, and we should fork the DAGStore repo and provide such functionality there.

Additionally, we should make issues in the upstream repo to discuss it with the original implementors and potentially submit a fix there to avoid maintenance of the fork.
@Wondertan Wondertan mentioned this issue Sep 15, 2022
Closed
45 tasks
@Wondertan Wondertan self-assigned this Sep 15, 2022
@Wondertan Wondertan added the area:shares Shares and samples label Sep 15, 2022
@Wondertan Wondertan mentioned this issue Sep 16, 2022
Closed
@distractedm1nd distractedm1nd mentioned this issue Sep 20, 2022
Merged
@distractedm1nd
Copy link
Collaborator

I didn't see you were assigned when I did this, sorry, just changed assignee to me if thats fine

@Wondertan
Copy link
Member Author

Totally fine

@distractedm1nd
Copy link
Collaborator

@Wondertan Closing because celestiaorg/dagstore#1 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@distractedm1nd distractedm1nd

Labels
area:shares Shares and samples
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@distractedm1nd @Wondertan