Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share/eds): ODSReader #1352

Closed
Tracked by #1099
distractedm1nd opened this issue Nov 11, 2022 · 0 comments · Fixed by #1377
Closed
Tracked by #1099

feat(share/eds): ODSReader #1352

distractedm1nd opened this issue Nov 11, 2022 · 0 comments · Fixed by #1377
Assignees
Labels
area:shares Shares and samples kind:feat Attached to feature PRs

Comments

@distractedm1nd
Copy link
Collaborator

Should be based on top of #1232 if not already merged when started.

There needs to be an ODSReader that takes the reader returned by GetCAR and limits the reader to the CAR header and first quadrant (ODS). The reader returned by ODSReader should only truncate from the end - meaning that the CAR header included in the reader returned by GetCAR will be included.

The amount of blocks to be read from the CAR should be determined after reading the CAR header, which contains the number of roots found in the CAR. The length of the ODS can be calculated with this information. The implementation of ODSReader will probably be the most elegant using carv1.NewReader.

@distractedm1nd distractedm1nd added area:shares Shares and samples kind:feat Attached to feature PRs labels Nov 11, 2022
@Wondertan Wondertan changed the title feat(edsstore): ODSReader feat(share/eds): ODSReader Nov 11, 2022
@distractedm1nd distractedm1nd linked a pull request Nov 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples kind:feat Attached to feature PRs
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants