Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share/eds: Return errUnsupportedOperation for Put/PutMany in the Blockstore once we update Bitswap #1440

Closed
Wondertan opened this issue Dec 6, 2022 · 1 comment
Labels
area:shares Shares and samples

Comments

@Wondertan
Copy link
Member

Bitswap, in the version we are currently using, stores data in the Blockstore automatically. However, as we are moving to rely on EDS Store, the Blockstore from it only gives read-only access to data, which means that Bitswap is doing unnecessary writes, and forces us to succeed in those writes so that Bitswap is not failing.

However, in the recent Bitswap changes, the storing functionality was removed, and now, it moved to the Blockservice layer. This means that after updating it, we can return the proper errUnsupportedOperation error and make Put/PutMany explicitly fail when someone uses them

@Wondertan Wondertan added the area:shares Shares and samples label Dec 6, 2022
@Wondertan
Copy link
Member Author

It is not relevant anymore, and we have to support this operation as per. #2424

@Wondertan Wondertan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples
Projects
None yet
Development

No branches or pull requests

1 participant