chore(deps): upgrade to celestia-app v2.0.0 #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rootulp
commented
Jun 6, 2024
rootulp
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
blob/blobtest/testing.go:31:25: copylocks: call of append copies lock value: github.com/celestiaorg/go-square/blob.Blob contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
blobs = append(blobs, *appBlob)
Because TestProveShares was failing due to nil pointer
|
@renaynay so I plan on reverting 79d8458 and then you can still rebase your PR on top of this one (or merge it into this one, whichever you prefer) |
This reverts commit 79d8458.
cristaloleg
reviewed
Aug 2, 2024
cristaloleg
reviewed
Aug 2, 2024
cristaloleg
reviewed
Aug 2, 2024
cristaloleg
reviewed
Aug 2, 2024
rach-id
reviewed
Aug 2, 2024
Wondertan
reviewed
Aug 5, 2024
vgonkivs
approved these changes
Aug 7, 2024
renaynay
approved these changes
Aug 7, 2024
Wondertan
approved these changes
Aug 7, 2024
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
Update celestia-node to use celestia-app v2.0.0. A few changes that were needed: - celestia-app v1.x had a shares package. celestia-app v2.x uses the shares package from go-square. - celestia-app v1.x had a blob.types package with `CreateCommitment`. celestia-app v2.x uses `CreateCommitment` from the go-square inclusion package. - I had to update extended header verification to allow `header.Version.App = 2`. Added unit tests. - celestia-app v1.x had a lot of functionality included in the `signer`. celestia-app v2.x split a `txClient` from the `signer`. See: celestiaorg/celestia-app#3433 - ~~I had to update `core_access.go` a lot. Mostly inspired by celestiaorg#3451 ## Testing I ran a [script](https://gist.github.com/rootulp/73ee382b4d533cb9da27fc675e9047c0) with: celestia-app v2.0.0-rc2 and configured it to upgrade at block height 3. celestia-node (built from this PR) continued to work: ``` 2024-07-09T18:13:27.040-0400 INFO header/store store/store.go:367 new head {"height": 2, "hash": "8776AEAF4114BD7E88E8DEC38445720D0BD857335BED99649957A43BB845EC87"} 2024-07-09T18:13:38.065-0400 INFO header/store store/store.go:367 new head {"height": 3, "hash": "63D5C64521A964290BD21658314DDF60146AE419FE99026003048F74D2886B35"} 2024-07-09T18:13:49.093-0400 INFO header/store store/store.go:367 new head {"height": 4, "hash": "FC7900918E716697A7CD6D9A4865B261F3E71D181F366E765AA53CF475223F9A"} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update celestia-node to use celestia-app v2.0.0. A few changes that were needed:
CreateCommitment. celestia-app v2.x usesCreateCommitmentfrom the go-square inclusion package.header.Version.App = 2. Added unit tests.signer. celestia-app v2.x split atxClientfrom thesigner. See: feat: add multi-account support celestia-app#3433I had to updatecore_access.goa lot. Mostly inspired by feat: support multiple accounts #3451Testing
I ran a script with: celestia-app v2.0.0-rc2 and configured it to upgrade at block height 3. celestia-node (built from this PR) continued to work: