feat(shwap/p2p): Bitswap Getter #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
walldiss
reviewed
Jul 23, 2024
ramin
reviewed
Jul 25, 2024
walldiss
reviewed
Jul 25, 2024
Wondertan
force-pushed
the
shwap-bitswap-getter
branch
from
9f9377b to
c4288b6
Compare
Wondertan
force-pushed
the
shwap-bitswap-getter
branch
from
c4288b6 to
b58c3fc
Compare
Wondertan
pushed a commit
that referenced
this pull request
Aug 7, 2024
add store getter implementation of shwap.Getter. Unit are not implemented for same reason as #3584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements new
Getterover Bitswap p2p composition.This PR does not intend to implement unit tests for the Getter itself. Adding them here is not trivial as we don't have the
Gettertest suite, which will soon be replaced with theAccessorinterface. The current coverage of everyBlockis sufficient to prove every method works whileGetteritself is simply an adapter. We need thisGettertemporary to accelerate testing ofShwapand replace it with anAccesoronce we allocate time for refactorings.