-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shwap): Add axis roots to Accessor #3586
feat(shwap): Add axis roots to Accessor #3586
Conversation
cbeefa7
to
3047f07
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## shwap #3586 +/- ##
========================================
Coverage ? 47.78%
========================================
Files ? 317
Lines ? 18708
Branches ? 0
========================================
Hits ? 8939
Misses ? 8621
Partials ? 1148 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first look, still need to go over new odsfile logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets mb add in the comment that the cache does not synchronize access of u\nderlying accessor
Add axis roots to all Accessor implementations. It will allow server side to handle namespace requests without the need to know exact rowIdxes beforehand.