Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shwap): Add axis roots to Accessor #3586

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

walldiss
Copy link
Member

Add axis roots to all Accessor implementations. It will allow server side to handle namespace requests without the need to know exact rowIdxes beforehand.

@walldiss walldiss added kind:feat Attached to feature PRs shwap labels Jul 22, 2024
@walldiss walldiss self-assigned this Jul 22, 2024
@walldiss walldiss force-pushed the add-axisRoots-to-accessor branch from cbeefa7 to 3047f07 Compare July 22, 2024 19:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 71.33333% with 43 lines in your changes missing coverage. Please review.

Please upload report for BASE (shwap@d807843). Learn more about missing BASE report.

Files Patch % Lines
share/eds/edstest/testing.go 0.00% 12 Missing ⚠️
store/file/ods.go 80.39% 6 Missing and 4 partials ⚠️
share/new_eds/proofs_cache.go 61.90% 4 Missing and 4 partials ⚠️
share/new_eds/close_once.go 0.00% 4 Missing ⚠️
store/cache/noop.go 0.00% 3 Missing ⚠️
share/new_eds/nd.go 50.00% 1 Missing and 1 partial ⚠️
share/new_eds/rsmt2d.go 60.00% 1 Missing and 1 partial ⚠️
share/root.go 0.00% 1 Missing ⚠️
store/store.go 95.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3586   +/-   ##
========================================
  Coverage         ?   47.78%           
========================================
  Files            ?      317           
  Lines            ?    18708           
  Branches         ?        0           
========================================
  Hits             ?     8939           
  Misses           ?     8621           
  Partials         ?     1148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first look, still need to go over new odsfile logic

share/new_eds/close_once.go Outdated Show resolved Hide resolved
share/new_eds/accessor.go Outdated Show resolved Hide resolved
share/new_eds/nd.go Outdated Show resolved Hide resolved
share/new_eds/proofs_cache.go Outdated Show resolved Hide resolved
share/new_eds/testing.go Outdated Show resolved Hide resolved
share/new_eds/testing.go Outdated Show resolved Hide resolved
share/root.go Outdated Show resolved Hide resolved
store/store.go Outdated Show resolved Hide resolved
store/store.go Outdated Show resolved Hide resolved
share/eds/edstest/testing.go Outdated Show resolved Hide resolved
share/eds/edstest/testing.go Outdated Show resolved Hide resolved
store/file/ods.go Show resolved Hide resolved
store/file/ods.go Outdated Show resolved Hide resolved
store/file/ods.go Show resolved Hide resolved
store/file/ods.go Outdated Show resolved Hide resolved
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets mb add in the comment that the cache does not synchronize access of u\nderlying accessor

share/new_eds/proofs_cache.go Outdated Show resolved Hide resolved
@walldiss walldiss merged commit c716c97 into celestiaorg:shwap Jul 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feat Attached to feature PRs shwap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants