Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store/files): ODSQ4 Closing audit #3691

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(store/files): ODSQ4 Closing audit #3691

merged 1 commit into from
Aug 26, 2024

Conversation

Wondertan
Copy link
Member

Fixes two issues:

  • incorrect error check
  • Close to wait for the Q4 being opened

@Wondertan Wondertan added kind:fix Attached to bug-fixing PRs shwap labels Aug 26, 2024
@Wondertan Wondertan self-assigned this Aug 26, 2024
@Wondertan Wondertan changed the title fix(store/files): closing audit fix(store/files): ODSQ4 Closing audit Aug 26, 2024
@github-actions github-actions bot added the kind:break! Attached to breaking PRs label Aug 26, 2024
@Wondertan Wondertan removed the kind:break! Attached to breaking PRs label Aug 26, 2024
@Wondertan Wondertan merged commit dd7b5cc into shwap Aug 26, 2024
41 of 57 checks passed
@Wondertan Wondertan deleted the shwap-close-fix branch August 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walldiss walldiss walldiss approved these changes

@renaynay renaynay Awaiting requested review from renaynay

@vgonkivs vgonkivs Awaiting requested review from vgonkivs

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@cristaloleg cristaloleg Awaiting requested review from cristaloleg

Assignees

@Wondertan Wondertan

Labels
kind:fix Attached to bug-fixing PRs shwap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wondertan @walldiss