Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shwap): io.ReadFull for read helpers #3696

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(shwap): io.ReadFull for read helpers #3696

merged 1 commit into from
Aug 28, 2024

Conversation

Wondertan
Copy link
Member

@Wondertan Wondertan commented Aug 28, 2024 •
edited
Loading

  • Gracefully handles case when Read reads enough data and returns io.EOF
    • Currently, the code fails in such a case.
  • Ensures we catch EOF as an UnexepectedEOF when not enough data given.

@Wondertan
fix(shwap): ReadFull for read helpers
f414611 
This ensures we catch EOF as an UnexepectedEOF when not enough data given.
@Wondertan Wondertan added kind:fix Attached to bug-fixing PRs shwap labels Aug 28, 2024
@Wondertan Wondertan self-assigned this Aug 28, 2024
@github-actions github-actions bot added the kind:break! Attached to breaking PRs label Aug 28, 2024
@Wondertan Wondertan changed the title fix(shwap): ReadFull for read helpers fix(shwap): io.ReadFull for read helpers Aug 28, 2024
@Wondertan Wondertan removed the kind:break! Attached to breaking PRs label Aug 28, 2024
@Wondertan Wondertan merged commit ed82a2e into shwap Aug 28, 2024
25 of 32 checks passed
@Wondertan Wondertan deleted the shwap-ids-readfull branch August 28, 2024 15:16
@walldiss walldiss mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay Awaiting requested review from renaynay

@vgonkivs vgonkivs Awaiting requested review from vgonkivs

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

@walldiss walldiss Awaiting requested review from walldiss

@cristaloleg cristaloleg Awaiting requested review from cristaloleg

Assignees

@Wondertan Wondertan

Labels
kind:fix Attached to bug-fixing PRs shwap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Wondertan