Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(fix): set asynctimerchan=1 on build #3761

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

walldiss
Copy link
Member

Set go:debug directive "asynctimerchan=1" until golang/go#69312 is fixed.

@walldiss walldiss added the kind:fix Attached to bug-fixing PRs label Sep 23, 2024
@walldiss walldiss self-assigned this Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (2469e7a) to head (e092fac).
Report is 196 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3761      +/-   ##
==========================================
+ Coverage   44.83%   45.50%   +0.67%     
==========================================
  Files         265      281      +16     
  Lines       14620    16059    +1439     
==========================================
+ Hits         6555     7308     +753     
- Misses       7313     7905     +592     
- Partials      752      846      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wondertan
Copy link
Member

Let's do it in go.mod instead as per (https://go.dev/doc/godebug). The main file also works, but it's buried somewhere deep instead of top level go.mod

Wondertan
Wondertan previously approved these changes Sep 23, 2024
@walldiss walldiss merged commit 3b7a579 into celestiaorg:main Sep 23, 2024
27 of 30 checks passed
@walldiss walldiss deleted the fix-timer-go23 branch September 23, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants