Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodebuilder/p2p/metrics): enforce init order for bitswap metrics #3763

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

walldiss
Copy link
Member

Bitswap metrics are initialised inside constructors and require prometheus to be injected before the call. This PR enforces initialisation order:

  1. set prometheus global Registrer
  2. inject bitswap metrics fabric
  3. set bitswap component scope though ctx
  4. init bitswap components

Wondertan
Wondertan previously approved these changes Sep 23, 2024
renaynay
renaynay previously approved these changes Sep 23, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@renaynay renaynay enabled auto-merge (squash) September 23, 2024 12:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.64%. Comparing base (2469e7a) to head (c10b9b9).
Report is 200 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/p2p/bitswap.go 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3763      +/-   ##
==========================================
+ Coverage   44.83%   45.64%   +0.80%     
==========================================
  Files         265      281      +16     
  Lines       14620    16071    +1451     
==========================================
+ Hits         6555     7335     +780     
- Misses       7313     7895     +582     
- Partials      752      841      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walldiss walldiss dismissed stale reviews from renaynay and Wondertan via c10b9b9 September 23, 2024 13:37
@walldiss walldiss force-pushed the fix-bitswap-metrics-injection branch from cef6258 to c10b9b9 Compare September 23, 2024 13:37
@renaynay renaynay merged commit 35cd3dd into celestiaorg:main Sep 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants